Skip to content

Patch: Switch to jest #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 17, 2022
Merged

Patch: Switch to jest #23

merged 7 commits into from
Mar 17, 2022

Conversation

ottopecz
Copy link

Patch: Switch to jest

Trolleymusic
Trolleymusic approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@Trolleymusic Trolleymusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pgrzesik
pgrzesik approved these changes Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

medikoo
medikoo reviewed Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had huge problems with Jest: serverless/serverless#6517

Jest is probably fine for front-end projects, but not for Node.js

@ottopecz
Copy link
Author

Hi @medikoo ... Thanks so much for the comment you left. I looked through the PR you created for serverless and obviously you researched the problem very thoroughly. All of your points in the comments section were spot on.
In our case though I just wanted to depart from this ancient version of jasmine and to do a cheap and quick migration to a modern "full-service" test framework... so that we can start making changes on the code of the plugin with confidence... Jest is very much inspired by Jasmine so I had to make very little changes as you can see. However in the future we'll definitelly consider to invest the effort and start using Mocha as you guys did with serverless. Thanks again Mate...

@ottopecz ottopecz merged commit edc2ac1 into master Mar 17, 2022
@ottopecz ottopecz deleted the chore/switch-to-jest branch March 17, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medikoo medikoo medikoo left review comments

@Trolleymusic Trolleymusic Trolleymusic approved these changes

@pgrzesik pgrzesik pgrzesik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ottopecz @medikoo @Trolleymusic @pgrzesik