Skip to content

chore: Move flask filter query logic from ViewModels to Services #1344

Closed
@AnEnigmaticBug

Description

@AnEnigmaticBug

Describe the chore
Some ViewModels form the flask filter query themselves and then pass it on to their correspoding Services. An example would be EventsViewModel forming the query in loadLocationEvents method and passing it to EventService.

The problem is that this moves the logic of retrieving data from Services(where it belongs) to ViewModels. The ViewModels should not be concerned with how the data is being retrieved. That is Services role.

So, the flask filter query should be formed in the Services and not in the ViewModels.

Would you like to work on the issue?

  • Yes
  • No

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions