fix: about event view on collapsing layout #1490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addiegupta
reviewed
Apr 1, 2019
app/src/main/java/org/fossasia/openevent/general/about/AboutEventFragment.kt
Show resolved
Hide resolved
addiegupta
reviewed
Apr 1, 2019
app/src/main/java/org/fossasia/openevent/general/about/AboutEventFragment.kt
Show resolved
Hide resolved
addiegupta
reviewed
Apr 1, 2019
app/src/main/java/org/fossasia/openevent/general/about/AboutEventFragment.kt
Show resolved
Hide resolved
addiegupta
reviewed
Apr 1, 2019
app/src/main/java/org/fossasia/openevent/general/about/AboutEventFragment.kt
Outdated
Show resolved
Hide resolved
|
@liveHarshit please review |
liveHarshit
reviewed
Apr 2, 2019
| <dimen name="collapsing_toolbar_height">220dp</dimen> | ||
| <dimen name="details_header_margin_top">40dp</dimen> | ||
| <dimen name="collapsing_toolbar_height">320dp</dimen> | ||
| <dimen name="details_header_margin_top">100dp</dimen> |
There was a problem hiding this comment.
@liveHarshit this is dimensions inside dimens.xml file... Can you please clarify your review?
liveHarshit
reviewed
Apr 3, 2019
| if (thisActivity is AppCompatActivity) thisActivity.supportActionBar?.title = event.name | ||
| } else { | ||
| rootView.detailsHeader.isVisible = true | ||
| if (thisActivity is AppCompatActivity) thisActivity.supportActionBar?.title = "" |
There was a problem hiding this comment.
Just cast one time, when you define the value for thisActivity.
There was a problem hiding this comment.
oh yeah, I forgot to do that, fixing now
There was a problem hiding this comment.
@liveHarshit I have fixed it
Details: - Load event image into the view - Set title bar to event name or "" when appBarLayout is collapsed or expaned Fixes: #1488
liveHarshit
reviewed
Apr 4, 2019
app/src/main/java/org/fossasia/openevent/general/about/AboutEventFragment.kt
Outdated
Show resolved
Hide resolved
Details: - Reduce thisActivity variable cast - Remove unused code - Set fitSystemWindows to avoid making extra white space above action bar and below status bar
|
Use setToolbar method from utils to setToolbar |
|
@angmas1 actually, I do import setToolbar from Utils file and do use it. Which part of the PR are you mentioning to? Thanks! |
iamareebjamal
approved these changes
Apr 5, 2019
angmas1
reviewed
Apr 5, 2019
| if (thisActivity is AppCompatActivity) { | ||
| if (Math.abs(offset) == appBarLayout.getTotalScrollRange()) { | ||
| rootView.detailsHeader.isVisible = false | ||
| thisActivity.supportActionBar?.title = event.name |
There was a problem hiding this comment.
I was referring to this part. Never mind, I will send a PR to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Fixes: #1488
Screenshots for the change:
