feat: Add no internet view on TicketsFragment #1492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detail: Add no internet card on Ticket Fragment and show it when there is no internet and no tickets retained in view model Fixes: #1491
liveHarshit
reviewed
Apr 1, 2019
|
|
||
| private fun loadTickets() { | ||
| if (!isNetworkConnected(context) && ticketsViewModel.tickets.value.isNullOrEmpty()) | ||
| showNoInternetScreen(true) |
There was a problem hiding this comment.
Why you are showing no internet screen if tickets value is null or empty?
There was a problem hiding this comment.
Because if the tickets information is loaded and already retained in the ViewModel then I think we can just show that information, no need for no internet card
There was a problem hiding this comment.
@anhanh11001 This is wrong. It should be shown from the ViewModel. I am merging this, but create an issue to move all network logic to VM. Use BroadcastReceiver to make it reactive
liveHarshit
previously approved these changes
Apr 1, 2019
iamareebjamal
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail:
Add no internet card on Ticket Fragment and show it when there is no internet and no tickets retained in view model
Fixes: #1491
Screenshots for the change:
