Skip to content

feat: add event types for search #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2019
Merged

feat: add event types for search #1521

merged 1 commit into from
Apr 7, 2019

Conversation

aggarwalpulkit596
Copy link
Contributor

@aggarwalpulkit596 aggarwalpulkit596 commented Apr 3, 2019 •
edited
Loading

Fixes #1519

Changes: Add filtering using event types

Screenshots for the change:

@aggarwalpulkit596 aggarwalpulkit596 changed the title [WIP]feat: add event types for search[skip ci] [WIP]feat: add event types for search Apr 4, 2019
@aggarwalpulkit596
Copy link
Contributor Author

@liveHarshit please review i'm not able to show results in the list view but the api call is happening you might find something

@liveHarshit
Copy link
Member

Why you are using offline database?

@liveHarshit
Copy link
Member

What is the API response? @GET("event-types?sort=name"). You are not specifying the name.

@aggarwalpulkit596
Copy link
Contributor Author

@liveHarshit api response is the list of all event types

@aggarwalpulkit596
Copy link
Contributor Author

Why you are using offline database?

@liveHarshit sorry i didn't get that

@aggarwalpulkit596
Copy link
Contributor Author

aggarwalpulkit596 commented Apr 4, 2019 •
edited by unfurl-links bot
Loading

@liveHarshit https://open-event-api-dev.herokuapp.com/v1/event-types?sort=name this is response to be precise

@liveHarshit
Copy link
Member

Why you are using offline database?

@liveHarshit sorry i didn't get that

For Dao file

@liveHarshit
Copy link
Member

liveHarshit commented Apr 4, 2019 •
edited by unfurl-links bot
Loading

@liveHarshit https://open-event-api-dev.herokuapp.com/v1/event-types?sort=name this is response to be precise

But on what basis you are shorting events. Replace name with the sorting parameter.

@aggarwalpulkit596
Copy link
Contributor Author

@liveHarshit we dont to fetch the event type every time and i've implemented it similar to eventbrite

@aggarwalpulkit596
Copy link
Contributor Author

aggarwalpulkit596 commented Apr 4, 2019 •
edited by unfurl-links bot
Loading

@liveHarshit https://open-event-api-dev.herokuapp.com/v1/event-types?sort=name this is response to be precise

But on what basis you are shorting events. Replace name with the sorting parameter.

@liveHarshit in this api call i just want list of all the event types so that user can select from one of them

@liveHarshit
Copy link
Member

liveHarshit commented Apr 4, 2019 •
edited by unfurl-links bot
Loading

@liveHarshit https://open-event-api-dev.herokuapp.com/v1/event-types?sort=name this is response to be precise

But on what basis you are shorting events. Replace name with the sorting parameter.

@liveHarshit in this api call i just want list of all the event types so that user can select from one of them

The user should select event type first, then call API for sorting events accordingly.

iamareebjamal
iamareebjamal reviewed Apr 4, 2019
View reviewed changes
app/src/main/java/org/fossasia/openevent/general/event/EventService.kt Outdated
else
eventTypesApi.getEventTypes()
.map {
eventTypesDao.insertEventTypes(it)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't insert these into DB, let them be fetched from network every time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal okay will revert this

@aggarwalpulkit596
Copy link
Contributor Author

@iamareebjamal @liveHarshit review

@aggarwalpulkit596
Copy link
Contributor Author

aggarwalpulkit596 commented Apr 4, 2019 •
edited
Loading

@iamareebjamal I'm having trouble understanding the query part for loading event can you help me out there rest all is implemented just i need to add event param to search query

@aggarwalpulkit596 aggarwalpulkit596 changed the title [WIP]feat: add event types for search feat: add event types for search Apr 4, 2019
@iamareebjamal
Copy link
Member

I don't understand?

@aggarwalpulkit596 aggarwalpulkit596 force-pushed the eventTypes branch 2 times, most recently from ad37433 to e007ca9 Compare April 7, 2019 06:00
@aggarwalpulkit596
Copy link
Contributor Author

@liveHarshit @iamareebjamal please review

@auto-label auto-label bot added the feature label Apr 7, 2019
@aggarwalpulkit596 aggarwalpulkit596 mentioned this pull request Apr 7, 2019
Closed
@aggarwalpulkit596
Copy link
Contributor Author

@iamareebjamal any update ?

@aggarwalpulkit596 aggarwalpulkit596 force-pushed the eventTypes branch 2 times, most recently from db28c72 to 5e32268 Compare April 7, 2019 20:02
@iamareebjamal iamareebjamal merged commit ad8f47a into fossasia:development Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aggarwalpulkit596 @liveHarshit @iamareebjamal