fix: set secondary color to editprofile buttons #1533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| @@ -79,12 +78,11 @@ | |||
|
|
|||
| </LinearLayout> | |||
|
|
|||
| <androidx.appcompat.widget.AppCompatButton | |||
| android:id="@+id/buttonUpdate" | |||
| <com.google.android.material.button.MaterialButton | |||
There was a problem hiding this comment.
Just use Button
Should work
There was a problem hiding this comment.
Are you sure? MaterialButton has different ripples and looks better IMO
There was a problem hiding this comment.
Is there a difference, the library should automatically inflate Button to MaterialButton
There was a problem hiding this comment.
Changed MaterialButton to Button in latest push
Fixes: fossasia#1532 Changes: - Changes color of update button and profile photo FAB to secondary color - Refactored 'buttonUpdate' to 'updateButton' for consistency - Moved a hardcoded string to string resources
addiegupta
changed the title
|
Is it working as expected? |
yes |
iamareebjamal
approved these changes
Apr 5, 2019
nikit19
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1532
Changes:
Screenshots for the change: