feat: add Event Types Chips #1565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggarwalpulkit596
force-pushed
the
eventTypesChips
branch
from
03f4e3a to
cca214a
Compare
aggarwalpulkit596
changed the title
aggarwalpulkit596
force-pushed
the
eventTypesChips
branch
from
cca214a to
7a929b2
Compare
|
@liveHarshit @iamareebjamal please review |
aggarwalpulkit596
force-pushed
the
eventTypesChips
branch
2 times, most recently
from
3cb14ed to
cefd4da
Compare
aggarwalpulkit596
force-pushed
the
eventTypesChips
branch
from
cefd4da to
92523de
Compare
|
@nikit19 review this one also |
nikit19
reviewed
Apr 10, 2019
app/src/main/java/org/fossasia/openevent/general/search/SearchResultsFragment.kt
Show resolved
Hide resolved
| val slug: String? | ||
| val id: Long, | ||
| val name: String, | ||
| val slug: String |
There was a problem hiding this comment.
why? These values will never be null?
There was a problem hiding this comment.
yes JSON-API id's can never be null and neither can name or slug
|
@liveHarshit @iamareebjamal anything left out ? |
iamareebjamal
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1561
Changes: Added event types to result fragment chips
Screenshots for the change:
