feat: Add Event FAQs #1623
Merged
feat: Add Event FAQs #1623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggarwalpulkit596
force-pushed
the
faqs
branch
3 times, most recently
from
cd3f591 to
ea72ff2
Compare
nikit19
reviewed
Apr 19, 2019
|
This api is not yet merged to prod server so waiting for that otherwise it is complete |
|
You don't use prod API, you use dev API |
|
I'm using prod server for testing |
|
@nikit19 review now |
You shouldn't |
|
@iamareebjamal okay I'll keep that in mind for future PR's |
|
@iamareebjamal review |
|
There should be an icon in the action bar which should open the FAQ fragment |
|
An entirely new fragment for faq ? Currently I'm showing them about event fargment |
|
Yeah, new fragment |
|
@nikit19 @iamareebjamal updated |
aggarwalpulkit596
force-pushed
the
faqs
branch
2 times, most recently
from
bbe8a3d to
dd61fec
Compare
|
Text in action bar is fine. Remove the text in Fragment |
|
@liveHarshit review |
|
@iamareebjamal updated |
|
@iamareebjamal anything left out? |
iamareebjamal
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1619
Changes: Added Event Faq's in About Event Fragment
Screenshots for the change:
