fix query,use jacksonObjectMapper and view holder crash #1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iamareebjamal @nikit19 please review |
|
|
| if (it != null) | ||
| addchips(it.name) | ||
| if (containerView.chipTags != null) { | ||
| event.eventType.let { |
There was a problem hiding this comment.
Suggested change
| event.eventType.let { | |
| event.eventType?.let { |
| addchips(it.name) | ||
| if (containerView.chipTags != null) { | ||
| event.eventType.let { | ||
| if (it != null) |
|
@iamareebjamal updated |
| event.eventTopic.let { | ||
| if (it != null) | ||
| } | ||
| event.eventTopic?.let { | ||
| addchips(it.name) |
There was a problem hiding this comment.
@iamareebjamal Klint test should have failed if the indentation was wrong
|
@iamareebjamal fixing in a minute |
|
@iamareebjamal updated |
iamareebjamal
approved these changes
Apr 21, 2019
nikit19
approved these changes
Apr 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1637
Changes: Use jacksonObjectMapper instead of ObjectMapper(),Do not add chip view in favourtie view items,nested query fix for location events
Screenshots for the change: