feat: Add submit feedbacks #1639
Conversation
|
@nikit19 @liveHarshit please review |
|
Also the feedback recyclerview isn't updating after feedback submission any ideas why ? |
|
@liveHarshit review |
Current logic used to prevent reloading of fragments on rotation is causing these bugs. #1520 is a similar bug. |
| } | ||
|
|
||
| private fun writefeedback() { | ||
| val layout = layoutInflater.inflate(R.layout.dialog_feedback, null) |
There was a problem hiding this comment.
Not needed directly put layout in setView of AlertDialog. I had to do this in changePassword dialog because I wanted to run code without button press.
There was a problem hiding this comment.
I think layout is being referred for getting text and add textChangedListeners. So I suppose its fine to inflate layout here
|
@iamareebjamal |
aggarwalpulkit596
changed the title
|
@iamareebjamal nm it was because of onlineApiResourceConverter.enableSerializationOption(SerializationFeature.INCLUDE_RELATIONSHIP_ATTRIBUTES) |
aggarwalpulkit596
changed the title
|
@nikit19 please review |
|
@iamareebjamal @nikit19 updated |
|
Build is failing |
|
@iamareebjamal updated |
app/src/main/java/org/fossasia/openevent/general/auth/UserId.kt
Outdated
Show resolved
Hide resolved
|
Resolved Conflicts. Should I squash them first ? |
| @@ -239,8 +238,6 @@ val networkModule = module { | |||
| EventSubTopic::class.java, Feedback::class.java, Speaker::class.java, | |||
| EventFAQ::class.java) | |||
|
|
|||
| onlineApiResourceConverter.enableSerializationOption(SerializationFeature.INCLUDE_RELATIONSHIP_ATTRIBUTES) | |||
There was a problem hiding this comment.
{
"data": {
"type": "feedback",
"attributes": {
"rating": "2.5",
"comment": "Awesome"
},
"relationships": {
"event": {
"data": {
"type": "event",
"id": "770"
}
},
"user": {
"data": {
"type": "user",
"id": "7625"
}
}
}
},
"included": [
{
"type": "user",
"id": "7625",
"attributes": {}
},
{
"type": "event",
"id": "770",
"attributes": {}
}
]
}
becuase in this post request Included was added
There was a problem hiding this comment.
OK. Got it. But won't it effect past modules
There was a problem hiding this comment.
nope I have checked it isn't affecting any modules it may have broken some code before but everything is working fine
app/src/main/java/org/fossasia/openevent/general/event/EventDetailsFragment.kt
Outdated
Show resolved
Hide resolved
|
@iamareebjamal updated |
Fixes #1633
Changes: Added option to submit feedback
Screenshots for the change: