-
Notifications
You must be signed in to change notification settings - Fork 553
feat: Add Free Stuff Filter #1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@aggarwalpulkit596 Please review this |
@iamareebjamal EventBrite has also put option to change |
In future PRs |
app/src/main/java/org/fossasia/openevent/general/search/SearchFilterFragment.kt
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,40 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<androidx.constraintlayout.widget.ConstraintLayout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use linear layout instead of constraint layout for better performance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ConstraintLayout
is to optimize and flatten the view hierarchy of your layouts by applying some rules to each view to avoid nesting. Currently Only one filter is added , but in future other filter would also be added, so for then this would be better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This layout can be easily achieved using linear layout and secondly it flatten the view heirarchy but at what cost and this is already single activity app and using constraint layout makes it even more expensive and time consuming so i would highly recommend using linear layout for such simple layouts
References
https://android.jlelse.eu/constraint-layout-performance-870e5f238100
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And Linear layout slows down only if there is nesting level of >3 and in this case it wouldn't be happening ever
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! thanks for the link. I would make changes surely.
Fixes #1609
Changes:
Screenshots for the change: