Skip to content

feat: Add Free Stuff Filter #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2019
Merged

feat: Add Free Stuff Filter #1642

merged 1 commit into from
Apr 23, 2019

Conversation

RotBolt
Copy link

@RotBolt RotBolt commented Apr 22, 2019

Fixes #1609

Changes:

  • Add Filter Search fragment (Currently Added Free stuff filter only - working)
  • Display Free events only after applying filter

Screenshots for the change:

  • Notice PGConf APAC its PAID event. After applying filter. Its not shown in the list

@auto-label auto-label bot added the feature label Apr 22, 2019
@RotBolt
Copy link
Author

RotBolt commented Apr 22, 2019

@aggarwalpulkit596 Please review this

@RotBolt
Copy link
Author

RotBolt commented Apr 22, 2019

@iamareebjamal EventBrite has also put option to change location , date and type. Should I also put these filters ? Currently Put Free event filter

@iamareebjamal
Copy link
Member

In future PRs

@@ -0,0 +1,40 @@
<?xml version="1.0" encoding="utf-8"?>
<androidx.constraintlayout.widget.ConstraintLayout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use linear layout instead of constraint layout for better performance

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConstraintLayout is to optimize and flatten the view hierarchy of your layouts by applying some rules to each view to avoid nesting. Currently Only one filter is added , but in future other filter would also be added, so for then this would be better

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This layout can be easily achieved using linear layout and secondly it flatten the view heirarchy but at what cost and this is already single activity app and using constraint layout makes it even more expensive and time consuming so i would highly recommend using linear layout for such simple layouts
References
https://android.jlelse.eu/constraint-layout-performance-870e5f238100

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And Linear layout slows down only if there is nesting level of >3 and in this case it wouldn't be happening ever

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! thanks for the link. I would make changes surely.

@iamareebjamal iamareebjamal merged commit 40168f0 into fossasia:development Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional filter for Free events (Like EventBrite)
4 participants