fix: Make chip not checkable and search possible #1659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -153,6 +153,7 @@ class FavoriteFragment : Fragment() { | |||
| private fun openSearchResult(time: String) { | |||
| SearchResultsFragmentArgs.Builder() | |||
| .setQuery("") | |||
| .setType("Anything") | |||
There was a problem hiding this comment.
Why hardcoding the type there's no point of chips if you're doing this you should make them as they were supposed to work instead of making a dirty fix
There was a problem hiding this comment.
@aggarwalpulkit596 I don't really get your point... So the problem is simply because the type in SearchResultFragment is set to null when being navigated from this, so results are not fetched. If I don't put the default type ("Anything") here, then sure I can put it in the SearchResultFragment, and that's pretty much the same
|
@liveHarshit please review |
2 tasks
Detail: In FavoriteFragment, make chips not clickable Make search possible by adding search type Fixes: #1655
liveHarshit
approved these changes
Apr 29, 2019
iamareebjamal
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail:
Fixes: #1655
Screenshots for the change:
