fix: Make search button possible #1684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detail: In my opinion, search button is the indication for searching, so it should not confuse users with different meaning, even with good intention. Fixes: #1673
iamareebjamal
approved these changes
Apr 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail:
There was a discussion between me and @thelimitbreaker on the use of search button. Currently, it is used to make the request for autosuggestion, which I find not really useful because from my experience: when I'm having a good internet connection, then the autosuggestion appear really well but if the connection is poor, then I'm blocked in that fragment and I cannot navigate to other fragment and use the app right the start
In my opinion, the search button is the indication for searching, so it should not confuse users with a different meaning, even with good intention.
Fixes: #1673