feat: Add session fragment #1693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anhanh11001 i already completed this PR and was waiting for #1646 to get merged |
app/src/main/java/org/fossasia/openevent/general/sessions/SessionWithEvent.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/sessions/sessiontype/SessionType.kt
Outdated
Show resolved
Hide resolved
nikit19
reviewed
Apr 30, 2019
|
|
||
| @Type("session") | ||
| @JsonNaming(PropertyNamingStrategy.KebabCaseStrategy::class) | ||
| @Entity |
There was a problem hiding this comment.
Database schema must have changed? I guess you didn't commit that?
There was a problem hiding this comment.
I think you mean an autogenerated json file in schema folder. Should I also commit that?
There was a problem hiding this comment.
I'm uploading it now.
|
@anhanh11001 build is failing |
|
@aggarwalpulkit596 I fixed the merge conflict. Please review |
aggarwalpulkit596
previously approved these changes
May 6, 2019
|
@iamareebjamal please review |
iamareebjamal
previously approved these changes
May 6, 2019
anhanh11001
dismissed stale reviews from iamareebjamal and aggarwalpulkit596
via
a26151b
|
Update: Resolved Conflicts |
|
@liveHarshit @nikit19 please review again, this PR has been here for a while |
liveHarshit
approved these changes
May 11, 2019
|
@iamareebjamal please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail:
Fixes: #1691
Screenshots for the change:
