fix: updated favourites on event navigation & continuous topic api calls #1707
+87
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/main/java/org/fossasia/openevent/general/event/EventDao.kt
Outdated
Show resolved
Hide resolved
|
@iamareebjamal now getting the events from db. |
iamanbansal
changed the title
iamanbansal
changed the title
|
Changes:
Video (ignore the bg noise) @iamareebjamal @anhanh11001 @liveHarshit @nikit19 review please
|
liveHarshit
reviewed
May 20, 2019
| .doFinally { | ||
| mutableShowShimmerResults.value = false | ||
| }.subscribe({ | ||
| mutableShowShimmerResults.value = false |
There was a problem hiding this comment.
Calls the doFInally action after this Flowable signals onError or onCompleted or gets canceled by the downstream.
Means it'll keep showing the shimmer even after the success.
liveHarshit
approved these changes
May 20, 2019
iamareebjamal
approved these changes
May 20, 2019
This was referenced May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1689
Changes: change flowable similar events to single events.