feat: Add enlarged QR Image + Increase brightness #1727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShridharGoel
suggested changes
May 8, 2019
app/src/main/java/org/fossasia/openevent/general/order/OrderDetailsFragment.kt
Outdated
Show resolved
Hide resolved
|
Shouldn't the enlarged QR code be a little bigger than this? Also, in my opinion, the 'Cancel' button can be removed and instead, clicking outside the box should close it. |
Ok, I'll try to find way to improve the size. Putting image view into a dialog was a bit trickier than I thought yesterday. |
Detail: - Set up click listener to enlarge QR Image - Increate brightness when clicking on QR Image. - Setting margin of created QR image small so that QR Image Dialog can contain large image. Fixes: #1215
|
UPDATE:
Current QR Image dialog looks like: |
liveHarshit
approved these changes
May 8, 2019
ShridharGoel
approved these changes
May 8, 2019
nikit19
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail:
Fixes: #1215
Screenshots for the change:
Somehow my screen recorder doesn't record the change in brightness. But it increases the brightness to maximum when dialog appear and return to current brightness when dismissing the dialog