fix: Retain searchview state in SearchFragment #1756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,11 +128,22 @@ class SearchFragment : Fragment() { | |||
| rootView.fabSearch.setOnClickListener { | |||
| queryListener.onQueryTextSubmit(searchView.query.toString()) | |||
| } | |||
|
|
|||
| if (searchViewModel.isQuerying) { | |||
| Handler().post { | |||
There was a problem hiding this comment.
This is a memory leak btw
There was a problem hiding this comment.
@addiegupta thanks for the warning, I will take a look at that. Initially I user this because there were some problems on rendering the view of the action bar. Will fix this
There was a problem hiding this comment.
@anhanh11001 😂😂 Wrong Aditya
Detail: Retain search query in SearchFragment and require focus when making search on screen rotation Fixes: #862
|
updated. please review @liveHarshit |
iamareebjamal
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail:
Fixes: #862
Screenshots for the change:
