Skip to content

feat: Add track for event #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2019
Merged

feat: Add track for event #1783

merged 1 commit into from
May 18, 2019

Conversation

anhanh11001
Copy link
Contributor

@anhanh11001 anhanh11001 commented May 18, 2019

Detail:

  • Delete Scope
  • Add track to session item view and session fragment
  • Remove wildcard imports

Fixes:: #1694

Screenshots

@mariobehling
Copy link
Member

Travis is failing. Please fix it.

@anhanh11001 anhanh11001 changed the title WIP - Summary: Add track for event feat: Add track for event May 18, 2019
@auto-label auto-label bot added the feature label May 18, 2019
@anhanh11001
Copy link
Contributor Author

updated

@iamareebjamal
Copy link
Member

Color code is not meant to be shown in that manner. Make it card header color

Detail:
- Delete Scope
- Add track to session item view and session fragment
- Remove wildcard imports

Fixes: #1694
@anhanh11001
Copy link
Contributor Author

anhanh11001 commented May 18, 2019

@iamareebjamal @liveHarshit updated, please review

@iamareebjamal iamareebjamal merged commit d316fa1 into fossasia:development May 18, 2019
@iamareebjamal
Copy link
Member

Great work

@anhanh11001 anhanh11001 deleted the 1694_track_under_session branch June 20, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants