feat: Add call for speaker section #1792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liveHarshit
previously approved these changes
May 19, 2019
| @@ -41,7 +43,7 @@ import org.fossasia.openevent.general.ticket.TicketIdConverter | |||
|
|
|||
| @Database(entities = [Event::class, User::class, SocialLink::class, Ticket::class, Attendee::class, | |||
| EventTopic::class, Order::class, CustomForm::class, Speaker::class, SpeakerWithEvent::class, Sponsor::class, | |||
| SponsorWithEvent::class, Session::class], version = 6) | |||
| SponsorWithEvent::class, Session::class, SpeakersCall::class], version = 6) | |||
There was a problem hiding this comment.
I think json file for version = 6 is not committed in development?
| compositeDisposable += eventService.getSpeakerCall(eventId) | ||
| .withDefaultSchedulers() | ||
| .doFinally { | ||
| mutableProgress.value = false |
There was a problem hiding this comment.
IMO it's better if you set default visibility of progress to GONE and set the mutableProgress value to true onSubscribe.
Detail: - Set up menu action to get to Speakers Call Section Fixes: #1631
|
updated |
liveHarshit
approved these changes
May 19, 2019
iamareebjamal
approved these changes
May 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail:
Fixes: #1631
Screenshots for the change:
