fix: Improve AttendeesFragment #1810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anhanh11001
changed the title
Detail: - Set up text change listener to retain the Attendee information in the ViewModel so that it survives screen rotation. - Move UI initialization function from ViewModel into Fragment - Move variables about logic or information from Fragment from Fragment to ViewModel to survive screen rotation. - Remove redundant methods. - Improve some wrong naming. Fixes: #1755
|
@liveHarshit please review |
liveHarshit
reviewed
May 25, 2019
|
No, the UI still looks the same |
liveHarshit
approved these changes
May 25, 2019
iamareebjamal
approved these changes
May 25, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail:
Fixes: #1755
Screenshots for the change:
