Skip to content

feat: Add checking required fields #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2019
Merged

feat: Add checking required fields #1859

merged 2 commits into from
May 30, 2019

Conversation

anhanh11001
Copy link
Contributor

Details:

  • Add checking required fields
  • Add hint for required fields

Fixes: #1857

Screenshots for the change:

Details:
- Add checking required fields
- Add hint for required fields

Fixes: #1857
@auto-label auto-label bot added the feature label May 30, 2019
@anhanh11001 anhanh11001 requested a review from liveHarshit May 30, 2019 04:06
Copy link
Member

@liveHarshit liveHarshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that these fields are must, because I don't find the same in front-end?

@anhanh11001
Copy link
Contributor Author

@liveHarshit I think so, which part of it do you find not necessary. For billing information, I only check it when the checkbox is ticked

@liveHarshit
Copy link
Member

I only check it when the checkbox is ticked

Okay then. 👍

@iamareebjamal iamareebjamal merged commit 45ce5c1 into fossasia:development May 30, 2019
@anhanh11001 anhanh11001 deleted the 1857_checking_required branch June 20, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add checking required fields on registering tickets
3 participants