Skip to content

feat: Improve Search Section #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2019
Merged

feat: Improve Search Section #1950

merged 1 commit into from
Jun 18, 2019

Conversation

anhanh11001
Copy link
Contributor

@anhanh11001 anhanh11001 commented Jun 13, 2019 •
edited
Loading

Details:

  • Change layout, text size,...
  • Remove Action bar and replace by toolbar for better looks
  • Set up better search section in SearchFragment

Fixes: #1948

Screenshots for the change:

@anhanh11001 anhanh11001 requested a review from liveHarshit June 13, 2019 00:42
@auto-label auto-label bot added the feature label Jun 13, 2019
@anhanh11001 anhanh11001 mentioned this pull request Jun 13, 2019
Closed
@ShridharGoel
Copy link
Member

In my opinion, it would be better if the options under Filter Search are on the left, with each option having the checkbox first and then the text, i.e., checkbox on the left of text.

@fossasia fossasia deleted a comment Jun 14, 2019
@fossasia fossasia deleted a comment Jun 14, 2019
@anhanh11001
Copy link
Contributor Author

anhanh11001 commented Jun 14, 2019 •
edited
Loading

Updated: @liveHarshit please review

@fossasia fossasia deleted a comment Jun 14, 2019
@anhanh11001 anhanh11001 mentioned this pull request Jun 16, 2019
Closed
@anhanh11001
Summary: Improve UI Search Section
cb72ddf 
Details:
- Improve UI Search Section (Add toolbar, background image,...)

Fixes: #1948
@fossasia fossasia deleted a comment Jun 17, 2019
@fossasia fossasia deleted a comment Jun 17, 2019
@iamareebjamal iamareebjamal merged commit 41c0714 into fossasia:development Jun 18, 2019
@anhanh11001 anhanh11001 deleted the 1948_search_ui branch June 20, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liveHarshit liveHarshit liveHarshit approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve UI on SearchFragment and related Search section
4 participants
@anhanh11001 @ShridharGoel @liveHarshit @iamareebjamal