feat: Implement option to apply discount codes #1960
Conversation
|
I'm getting following exception for all discount APIs - |
|
You are not an admin, why should you be able to see all discount codes? |
Got it, so I need to post the discount code then handle the response from the server. ? |
| val event: Event | ||
| val event: Event? = null, | ||
| @Relationship("tickets") | ||
| val tickets: List<Ticket>? = null |
There was a problem hiding this comment.
I'm getting following response -
DiscountCode(id=7, code=FOSSASIA, validFrom=2019-06-10T05:48:37.962000+00:00, minQuantity=1, createdAt=2019-06-10T05:49:06.179000+00:00, ticketsNumber=5, value=10.0, maxQuantity=1, isActive=true, usedFor=ticket, validTill=2019-08-16T18:30:00+00:00, discountUrl=https://fossasia.github.io/open-event-frontend/e/7376e026?code=FOSSASIA, type=amount, event=null, tickets=null)
How can I store that relationship object to relate it with event and tickets -
"relationships": {
"events": {
"links": {
"self": "/v1/discount-codes/4/relationships/events",
"related": "/v1/discount-codes/4/events"
}
},
"tickets": {
"links": {
"self": "/v1/discount-codes/1/relationships/tickets",
"related": "/v1/discount-codes/1/tickets"
}
}
}
For this DiscountCode class, they are getting null.
There was a problem hiding this comment.
They are null. You haven't included them in the query. Secondly, instead of getting tickets of discount code, you should get discount code of ticket
There was a problem hiding this comment.
you should get discount code of ticket
I thought it will also give HTTP 401 UNAUTHORIZED. Working 👍
There was a problem hiding this comment.
HTTP 401 UNAUTHORIZED
Same for end point: /v1/tickets/{ticket_id}/discount-codes{?sort,filter}
There was a problem hiding this comment.
Yeah, I remebered. Obviously you can't see the discount codes. Or what would be the point. Imagine DigitalOcean API showing that BLACKOUT100 will give you 100% off
Why you need to fetch the discount codes?
There was a problem hiding this comment.
Okay, got it. You want to say that endpoint /v1/discount-codes/{code} should also give HTTP 401 UNAUTHORIZED?
There was a problem hiding this comment.
Which I'm using currently
There was a problem hiding this comment.
OK, if you have got a discount code, it doesn't throw the error? If so, then it is fine 👍
There was a problem hiding this comment.
OK, if you have got a discount code, it doesn't throw the error? If so, then it is fine
Yes, that's I'm using. Fetching details after submitting the discount code.
There was a problem hiding this comment.
If so, then it is fine
@iamareebjamal Please review!
liveHarshit
force-pushed
the
1778
branch
3 times, most recently
from
47e8433 to
f1c15c0
Compare
liveHarshit
changed the title
app/src/main/java/org/fossasia/openevent/general/ticket/TicketViewHolder.kt
Outdated
Show resolved
Hide resolved
|
PRF |
@anhanh11001 Please review. |
| if (currentDiscountCode != null) | ||
| holder.bind(ticket, selectedListener, eventCurrency, qty, currentDiscountCode) | ||
| else | ||
| holder.bind(ticket, selectedListener, eventCurrency, qty) |
There was a problem hiding this comment.
currentDiscountCode != null is unnecessary I think:
just add holder.bind(ticket, selectedListener, eventCurrency, qty, currentDiscountCode)
There was a problem hiding this comment.
Yes right, that's why I have take null as a default value, forgot to change it. 👍
Fixes #1778