feat: Add zip in multiple network calls #2010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liveHarshit
previously approved these changes
Jun 26, 2019
app/src/main/java/org/fossasia/openevent/general/event/EventDetailsFragment.kt
Outdated
Show resolved
Hide resolved
anhanh11001
requested review from
iamareebjamal
and removed request for
iamareebjamal
nikit19
approved these changes
Jun 26, 2019
|
PR looks good. May be try re running the build |
|
@nikit19 updated. I just didn't know why build failed earlier. I basically changed nothing |
iamareebjamal
previously requested changes
Jun 28, 2019
app/src/main/java/org/fossasia/openevent/general/event/EventDetailsFragment.kt
Outdated
Show resolved
Hide resolved
Details: - Add zip for flowable in multiple network calls for similar events - Make favorite button works in SimilarEvent list Fixes: #2009
liveHarshit
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Fixes: #2009