Skip to content

feat: Ask for rating on first order #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

liveHarshit
Copy link
Member

Fixes #2002

@auto-label auto-label bot added the feature label Jun 27, 2019
@liveHarshit liveHarshit requested a review from anhanh11001 June 27, 2019 17:36
}.show()
layout.rateEventyayButton.setOnClickListener {
alertDialog.dismiss()
val appPackageName = "com.eventyay.attendee"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't hardcode. Fetch actual

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal But there is something wrong. The package name is different. In the repo, it is org.fossasia.openevent.general
https://github.com/fossasia/open-event-android/blob/91eda72bab0ed86f564ed26d259b7acb1eff7c7a/app/src/main/AndroidManifest.xml#L3 And on play store it is com.eventyay.attendee https://play.google.com/store/apps/details?id=com.eventyay.attendee

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See build.gradle

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Contributor

@anhanh11001 anhanh11001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment from Areeb, rest looks good to me

@iamareebjamal iamareebjamal merged commit b546864 into fossasia:development Jun 28, 2019
@liveHarshit liveHarshit deleted the 2002 branch June 29, 2019 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ask for rating after successful ticket order
3 participants