Skip to content

feat: Add ticket details #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2019
Merged

feat: Add ticket details #2031

merged 1 commit into from
Jul 1, 2019

Conversation

anhanh11001
Copy link
Contributor

Details:

  • Add ticket description
  • Add ticket start/end date
  • Add see more/less section about the ticket

Fixes: #2030

Screenshots for the change:
ezgif-4-7cb4a83bc8e7

@auto-label auto-label bot added the feature label Jun 30, 2019
nikit19
nikit19 reviewed Jul 1, 2019
View reviewed changes
Copy link
Member

@nikit19 nikit19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, fix conflicts

@anhanh11001
Summary: Add ticket details
76b9e63 
Details:
- Add sales date check
- Add ticket description

Fixes: #2030
@anhanh11001
Copy link
Contributor Author

Resolved conflicts

@anhanh11001 anhanh11001 requested a review from liveHarshit July 1, 2019 07:41
@iamareebjamal iamareebjamal merged commit ba1f54a into fossasia:development Jul 1, 2019
@anhanh11001 anhanh11001 deleted the 2030_ticket_details branch July 1, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikit19 nikit19 nikit19 left review comments

@liveHarshit liveHarshit liveHarshit approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ticket details in TicketFragment
4 participants
@anhanh11001 @nikit19 @liveHarshit @iamareebjamal