Skip to content

fix: wrong order status #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2019
Merged

fix: wrong order status #2032

merged 1 commit into from
Jul 2, 2019

Conversation

anhanh11001
Copy link
Contributor

Details:

  • When initializing an order, the order status used is "INITIALIZING", not "PENDING".
  • Don't have to cancel order when time counter goes down as the server automatically hanndle it

Fixes: #2026

@auto-label auto-label bot added the fix label Jun 30, 2019
@iamareebjamal
Copy link
Member

Also fix the timer minutes, it's been changed on the server

@anhanh11001
Copy link
Contributor Author

What change is needed to be made?

From what I understand, it is already handled correctly as the time counts down based on the registration time entered by the organizer, and when time goes up, the app redirects the user to the previous fragment.

The server turn "initializing" order into "expired" whenever a GET request for order it made and order start time + registration time < current time

@iamareebjamal
Copy link
Member

The countdown time has changed to 15 minutes or so. Confirm on gitter channel

@anhanh11001
Summary: Fix order status
cd31a11 
Details:
- When initialize an order, order status used is "INITIALIZING", not "PENDING".
- Don't have to cancel order when time counter goes down as the server automatically hanndle it
- Change time count down to 15 minutes

Fixes: #2026
@anhanh11001 anhanh11001 requested a review from liveHarshit July 2, 2019 00:35
@nikit19 nikit19 merged commit 6959d7e into fossasia:development Jul 2, 2019
@iamareebjamal iamareebjamal mentioned this pull request Jul 2, 2019
Open
@anhanh11001 anhanh11001 deleted the 2026_wrong_order_status branch July 2, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikit19 nikit19 nikit19 approved these changes

@liveHarshit liveHarshit liveHarshit approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong order status when holding ticket for user
4 participants
@anhanh11001 @iamareebjamal @nikit19 @liveHarshit