Skip to content

fix: Included tax for tickets #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Conversation

liveHarshit
Copy link
Member

@liveHarshit liveHarshit commented Aug 4, 2019

Fixes #2233

@auto-label auto-label bot added the fix label Aug 4, 2019
nikit19
nikit19 previously approved these changes Aug 4, 2019
Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When showing price of ticket in tax included, you have to reduce the tax from it.

Ticket : 100

Price: 91

Tax: 9

If I understand it correctly

anhanh11001
anhanh11001 previously approved these changes Aug 5, 2019
@liveHarshit
Copy link
Member Author

When showing price of ticket in tax included, you have to reduce the tax from it.

Ticket : 100

Price: 91

Tax: 9

If I understand it correctly

Yes but I was not sure about is on frontend -
image
image

Will update as you suggested 👍

@liveHarshit
Copy link
Member Author

Updated

@iamareebjamal
Copy link
Member

OK, I thought it displayed like that in frontend. Please stick with the way frontend shows it

@liveHarshit
Copy link
Member Author

OK, I thought it displayed like that in frontend. Please stick with the way frontend shows it

But frontend is not displaying ticket price details. It is according to the Eventbrite. So that is correct imo

@iamareebjamal iamareebjamal merged commit 39813ec into fossasia:development Aug 5, 2019
@liveHarshit liveHarshit deleted the 2233 branch August 5, 2019 08:28
liveHarshit added a commit to liveHarshit/open-event-attendee-android that referenced this pull request Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle tax for included price and free tickets
4 participants