Skip to content

fix: App crash when no location found #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2019
Merged

fix: App crash when no location found #2259

merged 1 commit into from
Aug 9, 2019

Conversation

anhanh11001
Copy link
Contributor

Fixes: #2255

Screenshots for the change:
ezgif-5-64aa352a246e

@auto-label auto-label bot added the fix label Aug 8, 2019
liveHarshit
liveHarshit previously approved these changes Aug 8, 2019
@liveHarshit
Copy link
Member

Fix build

@anhanh11001
Copy link
Contributor Author

Fix build

fixed

Copy link
Member

@liveHarshit liveHarshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about fdroid build?

@liveHarshit
Copy link
Member

@anhanh11001 We are using google services with location manager for play store build for fetching faster and for fdroid build, only location manager is used.

@fossasia fossasia deleted a comment Aug 9, 2019
@fossasia fossasia deleted a comment Aug 9, 2019
Copy link
Member

@liveHarshit liveHarshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Fix build 👍

@fossasia fossasia deleted a comment Aug 9, 2019
@anhanh11001
Copy link
Contributor Author

@liveHarshit fixed

@iamareebjamal iamareebjamal merged commit 47a24ed into fossasia:development Aug 9, 2019
@anhanh11001 anhanh11001 deleted the 2255_location_app_crash branch August 9, 2019 19:13
liveHarshit pushed a commit to liveHarshit/open-event-attendee-android that referenced this pull request Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes on searching events in my location
3 participants