feat: Remove useless native binaries from paypal SDK (#2426) #2427
Conversation
|
@iamareebjamal change is quite a significant whosever found it out kudos to that person |
|
Thanks Can you confirm that no functionality is broken due to this |
app/build.gradle
Outdated
| @@ -94,6 +94,29 @@ android { | |||
| } | |||
| packagingOptions { | |||
| pickFirst 'kotlin/**' | |||
| exclude 'AndroidManifest.xml' | |||
There was a problem hiding this comment.
Also, add a comment that following exclusions are due to Paypal SDK
|
Basic functionality is all good i couldn't check functionality of Paypal though😅 |
|
That's what's important |
|
I'll try to check that too |
|
@liveHarshit can you suggest a method to dry run the payment I guess while implementing the PayPal you tried something |
|
Just try to do paypal payment, don't click on pay. If it can reach that step, it means it is working |
|
That was already working 😅 I thought you wanted me to check the end to end payment |
|
OK, so paypal page or dialog is opening up correctly? Then please complete the requested changes |
aggarwalpulkit596
force-pushed
the
apkSize
branch
from
d1d8857 to
83aa790
Compare
|
@iamareebjamal done |
app/build.gradle
Outdated
| packagingOptions { | ||
| pickFirst 'kotlin/**' | ||
| exclude 'AndroidManifest.xml' |
There was a problem hiding this comment.
Adding this will remove Manifest when anyone tries to decompile the apk and it doesn't affect the functionality
There was a problem hiding this comment.
But it is unneeded. Why we need to remove the manifest?
There was a problem hiding this comment.
Okay will remove this 😅
aggarwalpulkit596
force-pushed
the
apkSize
branch
from
83aa790 to
66dcd05
Compare
|
Changes Requested Completed @iamareebjamal |
…ossasia#2427) Signed-off-by: rcs10 <dhanueshrc28@gmail.com>
Fixes #2426
Changes: Remove useless native binaries from PayPal SDK
Screenshots for the change:
