Skip to content

[db] Fix collation drift with old installations #20916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

geropl
Copy link
Member

@geropl geropl commented Jun 20, 2025

Description

Fixes an issue where in very old installations we have a case of COLLATION drift in two tables.

This PR fixes the issue by:

  1. explicitly setting the default COLLATION (depending on MySQL version)
  2. CONVERT ... COLLATE (depending on MySQL version)

We did extensive testing on a) data consistency and b) runtime impact of the migrations which is negligible (<8s). ✔️

Related Issue(s)

Fixes CLC-1303
Fixes CLC-1439

How to test

  1. see here for the test protocol, and verify it invalidates all concerns ✔️
  2. smoke test:
  1. CI tests are 🟢 : ✔️

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@geropl geropl force-pushed the gpl/1303-fix-collation branch from 55f2b34 to 4a5b27e Compare June 20, 2025 09:48
@roboquat roboquat added size/M and removed size/XL labels Jun 20, 2025
@geropl
Copy link
Member Author

geropl commented Jun 20, 2025

Let's merge this on Monday 🤝

Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants