x/tools/gopls/internal/test: shutdown failures with "directory not empty"

[gopherbot]

#!watchflakes
default <- pkg ~ `^golang.org/x/tools/gopls/internal/test` && `directory not empty`

Issue created automatically to collect these failures.

Example (log):

serve.go:443: debug server listening at http://localhost:49278
serve.go:443: debug server listening at http://localhost:49279
goroutine profile: total 10
2 @ 0x103cf4e 0x1036137 0x106a7a5 0x10a9387 0x10ae86c 0x10ae85a 0x1240c49 0x125537e 0x1254550 0x163bfe4 0x181b4a5 0x181b4a6 0x1070d21
#	0x106a7a4	internal/poll.runtime_pollWait+0x84					/tmp/buildlet/go/src/runtime/netpoll.go:343
#	0x10a9386	internal/poll.(*pollDesc).wait+0x26					/tmp/buildlet/go/src/internal/poll/fd_poll_runtime.go:84
#	0x10ae86b	internal/poll.(*pollDesc).waitRead+0x2ab				/tmp/buildlet/go/src/internal/poll/fd_poll_runtime.go:89
#	0x10ae859	internal/poll.(*FD).Accept+0x299					/tmp/buildlet/go/src/internal/poll/fd_unix.go:611
#	0x1240c48	net.(*netFD).accept+0x28						/tmp/buildlet/go/src/net/fd_unix.go:172
#	0x125537d	net.(*TCPListener).accept+0x1d						/tmp/buildlet/go/src/net/tcpsock_posix.go:152
...
1 @ 0x103cf4e 0x104d305 0x1264985 0x1070d21
#	0x1264984	golang.org/x/tools/internal/jsonrpc2.Serve+0x384	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve.go:112

1 @ 0x103cf4e 0x106d885 0x13d5b76 0x1070d21
#	0x106d884	time.Sleep+0x124					/tmp/buildlet/go/src/runtime/time.go:195
#	0x13d5b75	golang.org/x/tools/gopls/internal/filecache.gc+0x275	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/filecache/filecache.go:507

--- FAIL: TestRenamePackage_NestedModule (3.61s)
    --- FAIL: TestRenamePackage_NestedModule/default (3.61s)
        runner.go:208: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /tmp/buildlet/tmp/gopls-test-4165152782/TestRenamePackage_NestedModule/default: directory not empty

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestRenamePackage_NestedModule"

2024-01-03 12:29 darwin-amd64-nocgo tools@a863a4fc go@f6b203c8 x/tools/gopls/internal/test/integration/misc.TestRenamePackage_NestedModule (log)

serve.go:443: debug server listening at http://localhost:49278
serve.go:443: debug server listening at http://localhost:49279
goroutine profile: total 10
2 @ 0x103cf4e 0x1036137 0x106a7a5 0x10a9387 0x10ae86c 0x10ae85a 0x1240c49 0x125537e 0x1254550 0x163bfe4 0x181b4a5 0x181b4a6 0x1070d21
#	0x106a7a4	internal/poll.runtime_pollWait+0x84					/tmp/buildlet/go/src/runtime/netpoll.go:343
#	0x10a9386	internal/poll.(*pollDesc).wait+0x26					/tmp/buildlet/go/src/internal/poll/fd_poll_runtime.go:84
#	0x10ae86b	internal/poll.(*pollDesc).waitRead+0x2ab				/tmp/buildlet/go/src/internal/poll/fd_poll_runtime.go:89
#	0x10ae859	internal/poll.(*FD).Accept+0x299					/tmp/buildlet/go/src/internal/poll/fd_unix.go:611
#	0x1240c48	net.(*netFD).accept+0x28						/tmp/buildlet/go/src/net/fd_unix.go:172
#	0x125537d	net.(*TCPListener).accept+0x1d						/tmp/buildlet/go/src/net/tcpsock_posix.go:152
...
1 @ 0x103cf4e 0x104d305 0x1264985 0x1070d21
#	0x1264984	golang.org/x/tools/internal/jsonrpc2.Serve+0x384	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve.go:112

1 @ 0x103cf4e 0x106d885 0x13d5b76 0x1070d21
#	0x106d884	time.Sleep+0x124					/tmp/buildlet/go/src/runtime/time.go:195
#	0x13d5b75	golang.org/x/tools/gopls/internal/filecache.gc+0x275	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/filecache/filecache.go:507

--- FAIL: TestRenamePackage_NestedModule (3.61s)
    --- FAIL: TestRenamePackage_NestedModule/default (3.61s)
        runner.go:208: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /tmp/buildlet/tmp/gopls-test-4165152782/TestRenamePackage_NestedModule/default: directory not empty

— watchflakes

[findleyr]

This must be caused by https://go.dev/cl/549415: shutdown doesn't wait for outstanding work on the snapshot.

[gopherbot]

Sorry, but there were parse errors in the watch flakes script.
The script I found was:

#!watchflakes
default <- pkg ~ "^golang.org/x/tools/gopls/internal/test" && "directory not empty"

And the problems were:

script:2.18: ~ requires backquoted regexp

See https://go.dev/wiki/Watchflakes for details.

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg ~ `^golang.org/x/tools/gopls/internal/test` && `directory not empty`

2024-01-03 12:29 darwin-amd64-12_0 tools@a863a4fc go@d2cb1401 x/tools/gopls/internal/test/integration/misc.TestThirdPartyPackageHighlight_Issue43511 (log)

serve.go:443: debug server listening at http://localhost:49277
serve.go:443: debug server listening at http://localhost:49278
goroutine profile: total 8
2 @ 0x103dbae 0x1036d97 0x106b545 0x10aa307 0x10af7ec 0x10af7da 0x1241ce9 0x125641e 0x12555f0 0x163d144 0x181c605 0x181c606 0x1071c41
#	0x106b544	internal/poll.runtime_pollWait+0x84					/tmp/buildlet/go/src/runtime/netpoll.go:343
#	0x10aa306	internal/poll.(*pollDesc).wait+0x26					/tmp/buildlet/go/src/internal/poll/fd_poll_runtime.go:84
#	0x10af7eb	internal/poll.(*pollDesc).waitRead+0x2ab				/tmp/buildlet/go/src/internal/poll/fd_poll_runtime.go:89
#	0x10af7d9	internal/poll.(*FD).Accept+0x299					/tmp/buildlet/go/src/internal/poll/fd_unix.go:611
#	0x1241ce8	net.(*netFD).accept+0x28						/tmp/buildlet/go/src/net/fd_unix.go:172
#	0x125641d	net.(*TCPListener).accept+0x1d						/tmp/buildlet/go/src/net/tcpsock_posix.go:152
...
#	0x1265a24	golang.org/x/tools/internal/jsonrpc2.Serve+0x384	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve.go:112

1 @ 0x103dbae 0x106e625 0x13d6c16 0x1071c41
#	0x106e624	time.Sleep+0x124					/tmp/buildlet/go/src/runtime/time.go:195
#	0x13d6c15	golang.org/x/tools/gopls/internal/filecache.gc+0x275	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/filecache/filecache.go:507

--- FAIL: TestThirdPartyPackageHighlight_Issue43511 (3.14s)
    --- FAIL: TestThirdPartyPackageHighlight_Issue43511/default (3.14s)
        runner.go:208: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: go command failed (stdout: ) (stderr: go: unlinkat /tmp/buildlet/tmp/gopls-test-280049913/TestThirdPartyPackageHighlight_Issue43511/default/gopath/pkg/mod: directory not empty
            ): exit status 1; removing files: <nil>

— watchflakes