Skip to content

[textual_inversion] use tokenizer.add_tokens to add placeholder_token #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2022
Merged

[textual_inversion] use tokenizer.add_tokens to add placeholder_token #357

merged 1 commit into from
Sep 5, 2022

Conversation

patil-suraj
Copy link
Contributor

Use tokenizer.add_tokens method to add the placeholder_token in tokenizer, this way we can detect if the token is already in the tokenizer and raise an error.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 5, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

anton-l
anton-l approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@anton-l anton-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice workaround!

@patil-suraj patil-suraj merged commit 55d6453 into main Sep 5, 2022
@patil-suraj patil-suraj deleted the update-textual-inversion branch September 5, 2022 07:42
natolambert pushed a commit that referenced this pull request Sep 7, 2022
@patil-suraj @natolambert
[textual_inversion] use tokenizer.add_tokens to add placeholder_token (…
d412cd8 
…#357)

use add_tokens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-l anton-l anton-l approved these changes

@patrickvonplaten patrickvonplaten Awaiting requested review from patrickvonplaten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patil-suraj @HuggingFaceDocBuilderDev @anton-l