Replace dropout_prob by dropout in vae
#595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
patil-suraj
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Good catch @younesbelkada ! It's okay to have different names for dropout in this case, they are not saved as part of model anyway.
PhaneeshB
pushed a commit
to nod-ai/diffusers
that referenced
this pull request
Mar 1, 2023
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
replace `dropout_prob` by `dropout` in `vae`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix https://github.com/huggingface/diffusers/pull/589/files#r975810155, this is probably not the best fix as it will break the consistency assumption between PT and Flax, but will enable consistent parameters naming for all Flax classes
Using
self.dropout = Dropout(self.dropout)leads to the errorcc @patil-suraj @patrickvonplaten @mishig25
Can confirm the PT->Flax equivalency test pass with this PR, which means that the FlaxVAE model is created correctly