refactor: pipelines readability improvements #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Russell <git@ryanrussell.org>
|
The documentation is not available anymore as the PR was closed or merged. |
pcuenca
approved these changes
Sep 23, 2022
| @@ -149,7 +149,7 @@ def __call__( | |||
| uncond_embeddings = self.text_encoder(uncond_input.input_ids, params=params["text_encoder"])[0] | |||
| context = jnp.concatenate([uncond_embeddings, text_embeddings]) | |||
|
|
|||
| # TODO: check it because the shape is different from Pytorhc StableDiffusionPipeline | |||
| # TODO: check it because the shape is different from Pytorch StableDiffusionPipeline | |||
There was a problem hiding this comment.
Actually I think we can remove this comment now. @patil-suraj
Signed-off-by: Ryan Russell <git@ryanrussell.org>
prathikr
pushed a commit
to prathikr/diffusers
that referenced
this pull request
Oct 26, 2022
* refactor: pipelines readability improvements Signed-off-by: Ryan Russell <git@ryanrussell.org> * docs: remove todo comment from flax pipeline Signed-off-by: Ryan Russell <git@ryanrussell.org> Signed-off-by: Ryan Russell <git@ryanrussell.org>
PhaneeshB
pushed a commit
to nod-ai/diffusers
that referenced
this pull request
Mar 1, 2023
…arily remove multiprocessing and TF gpu support. (huggingface#602)" (huggingface#622) This reverts commit fe61881.
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* refactor: pipelines readability improvements Signed-off-by: Ryan Russell <git@ryanrussell.org> * docs: remove todo comment from flax pipeline Signed-off-by: Ryan Russell <git@ryanrussell.org> Signed-off-by: Ryan Russell <git@ryanrussell.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Russell git@ryanrussell.org
Description
readability cleanup -- including var renaming -- in
src/diffusers/pipelines/stable_diffusion/More details
offsensive->offensivePytorhc->Pytorchsafety_cheker_input->safety_checker_inputconcet_idx->concept_idxNotes
I was able to go through your
venvsetup and runmake styleandmake quality(nothing recommended), but still am not 100% sure this will match your CI runner yet. I've been having problems matching my machines black/isort lint with your make script(versions), hopefully there are no linting issues here or moving forward.-r