Skip to content

Better steps deprecation for LMS #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Better steps deprecation for LMS #753

merged 2 commits into from
Oct 6, 2022

Conversation

anton-l
Copy link
Member

@anton-l anton-l commented Oct 6, 2022

No description provided.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 6, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge for me!

I'm assuming though that:

  • timesteps are never ints
  • Python/PyTorch never recognizes 9.0 as in int

@anton-l
Copy link
Member Author

anton-l commented Oct 6, 2022

timesteps are never ints

Correct for LMS and pipelines that use its scheduler.timesteps.

Python/PyTorch never recognizes 9.0 as in int

Yes, this is only true for comparison with __eq__.

@anton-l anton-l merged commit 0883968 into main Oct 6, 2022
@anton-l anton-l deleted the lms-steps-deprecation branch October 6, 2022 13:51
prathikr pushed a commit to prathikr/diffusers that referenced this pull request Oct 26, 2022
* Better steps deprecation for LMS

* upd
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* Better steps deprecation for LMS

* upd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants