Skip to content

update flax scheduler API #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 13, 2022
Merged

update flax scheduler API #822

merged 7 commits into from
Oct 13, 2022

Conversation

patil-suraj
Copy link
Contributor

@patil-suraj patil-suraj commented Oct 13, 2022

Align Flax scheduler API with PyTorch

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 13, 2022

The documentation is not available anymore as the PR was closed or merged.

@@ -196,14 +199,31 @@ def set_timesteps(self, state: PNDMSchedulerState, num_inference_steps: int, sha
)

return state.replace(
timesteps=jnp.concatenate([state.prk_timesteps, state.plms_timesteps]).astype(jnp.int64),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double precision values are not available by default injax cf https://github.com/google/jax#current-gotchas

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kashif
Copy link
Contributor

kashif commented Oct 13, 2022

LGTM!

@patil-suraj patil-suraj merged commit 0a09af2 into main Oct 13, 2022
@patil-suraj patil-suraj deleted the flax-schedulers branch October 13, 2022 13:40
prathikr pushed a commit to prathikr/diffusers that referenced this pull request Oct 26, 2022
* update flax scheduler API

* remoev set format

* fix call to scale_model_input

* update flax pndm

* use int32

* update docstr
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* update flax scheduler API

* remoev set format

* fix call to scale_model_input

* update flax pndm

* use int32

* update docstr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants