-
Notifications
You must be signed in to change notification settings - Fork 6.1k
fix: ValueError when using FromOriginalModelMixin in subclasses #8440 #8454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngface#8440 (cherry picked from commit 9285997)
DN6
reviewed
Jun 11, 2024
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
I made 2 commits to 1. resolve the review, 2. remove the redundant code fragments of the original code |
DN6
reviewed
Jun 11, 2024
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Hi @fkcptlst I will resolve the issues with the CI and merge this soon. Thanks for being patient. |
DN6
approved these changes
Jun 27, 2024
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
…#8454) * fix: ValueError when using FromOriginalModelMixin in subclasses #8440 (cherry picked from commit 9285997) * Update src/diffusers/loaders/single_file_model.py Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com> * Update single_file_model.py * Update single_file_model.py --------- Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com> Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 9285997)
What does this PR do?
Fixes # (issue)
#8440
Before submitting
FromOriginalModelMixin
in subclasses #8440documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@DN6