correct attention_head_dim for JointTransformerBlock
#8608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
DN6
reviewed
Jul 1, 2024
| @@ -81,7 +81,7 @@ def __init__( | |||
| JointTransformerBlock( | |||
| dim=self.inner_dim, | |||
| num_attention_heads=num_attention_heads, | |||
| attention_head_dim=self.inner_dim, | |||
| attention_head_dim=attention_head_dim, | |||
There was a problem hiding this comment.
Should this also be self.config.attention_head_dim to match transformer_sd3.py?
DN6
reviewed
Jul 1, 2024
| @@ -128,9 +128,9 @@ def __init__(self, dim, num_attention_heads, attention_head_dim, context_pre_onl | |||
| query_dim=dim, | |||
| cross_attention_dim=None, | |||
| added_kv_proj_dim=dim, | |||
| dim_head=attention_head_dim // num_attention_heads, | |||
There was a problem hiding this comment.
This won't break? Wouldn't the value of dim_head be computed differently?
There was a problem hiding this comment.
well no
currently dim_head=attention_head_dim // num_attention_heads with attention_head_dim and num_attention_heads passed from SD3ControlNetModel like this
* attention_head_dim=self.inner_dim
*
self.inner_dim = num_attention_heads * attention_head_dim
* -> so basically
attention_head_dim is num_attention_heads * attention_head_dim*
num_attention_heads is num_attention_heads* -> so
dim_heads here are just attention_head_dim we used to configure the model, and if we pass it down correctly, we can use it directly
There was a problem hiding this comment.
Ahh I see. Thanks for the explaining! 🙏🏽
yiyixuxu
commented
Jul 1, 2024
DN6
approved these changes
Jul 2, 2024
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
* add * update sd3 controlnet * Update src/diffusers/models/controlnet_sd3.py --------- Co-authored-by: yiyixuxu <yixu310@gmail,com> Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.