Skip to content

fix load sharded checkpoint from a subfolder (local path) #8913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

yiyixuxu
Copy link
Collaborator

fix #8898

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

)
if subfolder is not None:
cached_folder = os.path.join(cached_folder, subfolder)
try:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. Just double-checking: you have run the GPU tests, yeah?

@sayakpaul sayakpaul merged commit 95a7832 into main Aug 1, 2024
18 checks passed
@yiyixuxu yiyixuxu deleted the fix-shard-subfolder-local branch August 27, 2024 21:04
sayakpaul added a commit that referenced this pull request Dec 23, 2024
fix

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants