[LoRA] fix: animate diff lora stuff. #8995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
a-r-r-o-w
approved these changes
Jul 27, 2024
a-r-r-o-w
added a commit
that referenced
this pull request
Jul 28, 2024
Merged
DN6
reviewed
Jul 29, 2024
src/diffusers/loaders/peft.py
Outdated
| @@ -31,6 +31,7 @@ | |||
| _SET_ADAPTER_SCALE_FN_MAPPING = { | |||
| "UNet2DConditionModel": _maybe_expand_lora_scales, | |||
| "SD3Transformer2DModel": lambda model_cls, weights: weights, | |||
| "UNetMotionModel": lambda model_cls, weights: weights, | |||
There was a problem hiding this comment.
I think _maybe_expand_lora_scales was applied in the UNetMotionModel since that was the default in UNet2DConditionalLoaderMixin
diffusers/src/diffusers/loaders/unet.py
Line 620 in c586aad
There was a problem hiding this comment.
Thanks! Fixed in 2cbcc24.
DN6
approved these changes
Jul 29, 2024
|
Cc: @a-r-r-o-w for rebasing. |
DN6
added a commit
that referenced
this pull request
Aug 7, 2024
* initial work draft for freenoise; needs massive cleanup * fix freeinit bug * add animatediff controlnet implementation * revert attention changes * add freenoise * remove old helper functions * add decode batch size param to all pipelines * make style * fix copied from comments * make fix-copies * make style * copy animatediff controlnet implementation from #8972 * add experimental support for num_frames not perfectly fitting context length, ocntext stride * make unet motion model lora work again based on #8995 * copy load video utils from #8972 * copied from AnimateDiff::prepare_latents * address the case where last batch of frames does not match length of indices in prepare latents * decode_batch_size->vae_batch_size; batch vae encode support in animatediff vid2vid * revert sparsectrl and sdxl freenoise changes * revert pia * add freenoise tests * make fix-copies * improve docstrings * add freenoise tests to animatediff controlnet * update tests * Update src/diffusers/models/unets/unet_motion_model.py * add freenoise to animatediff pag * address review comments * make style * update tests * make fix-copies * fix error message * remove copied from comment * fix imports in tests * update --------- Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* fix: animate diff lora stuff. * fix scaling function for UNetMotionModel * emoty
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
* initial work draft for freenoise; needs massive cleanup * fix freeinit bug * add animatediff controlnet implementation * revert attention changes * add freenoise * remove old helper functions * add decode batch size param to all pipelines * make style * fix copied from comments * make fix-copies * make style * copy animatediff controlnet implementation from #8972 * add experimental support for num_frames not perfectly fitting context length, ocntext stride * make unet motion model lora work again based on #8995 * copy load video utils from #8972 * copied from AnimateDiff::prepare_latents * address the case where last batch of frames does not match length of indices in prepare latents * decode_batch_size->vae_batch_size; batch vae encode support in animatediff vid2vid * revert sparsectrl and sdxl freenoise changes * revert pia * add freenoise tests * make fix-copies * improve docstrings * add freenoise tests to animatediff controlnet * update tests * Update src/diffusers/models/unets/unet_motion_model.py * add freenoise to animatediff pag * address review comments * make style * update tests * make fix-copies * fix error message * remove copied from comment * fix imports in tests * update --------- Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As internally reported by @a-r-r-o-w:
https://huggingface.slack.com/archives/C065E480NN9/p1722091746614339
I don't know much about the AnimateDiff LoRA tests but I think we should consider how we can catch these in PRs. So, I will defer to @DN6 here.