Skip to content

Updates deps for pipeline test fetcher #9033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Updates deps for pipeline test fetcher #9033

merged 1 commit into from
Aug 1, 2024

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented Aug 1, 2024

What does this PR do?

Install test dependencies on pipeline test fetcher. Needed for pipelines that have externals dependencies such as Kolors.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6 DN6 requested a review from sayakpaul August 1, 2024 06:29
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single comment.

@@ -32,7 +32,7 @@ jobs:
fetch-depth: 2
- name: Install dependencies
run: |
pip install -e .
pip install -e [test]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be

pip install .[test]

@DN6 DN6 merged commit c646fbc into main Aug 1, 2024
10 checks passed
DN6 added a commit that referenced this pull request Aug 1, 2024
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants