[Flux] allow tests to run #9050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
commented
Aug 2, 2024
| @@ -123,6 +122,7 @@ def forward( | |||
| ) | |||
|
|
|||
| hidden_states = torch.cat([attn_output, mlp_hidden_states], dim=2) | |||
| gate = gate.unsqueeze(1) | |||
There was a problem hiding this comment.
Otherwise, will fail for multiple images.
sayakpaul
commented
Aug 2, 2024
Comment on lines
+378
to
+379
| dtype = self.text_encoder.dtype if self.text_encoder is not None else self.transformer.dtype | ||
| text_ids = torch.zeros(batch_size, prompt_embeds.shape[1], 3).to(device=device, dtype=dtype) |
sayakpaul
commented
Aug 2, 2024
| text_ids = torch.zeros(batch_size, prompt_embeds.shape[1], 3).to(device=device, dtype=self.text_encoder.dtype) | ||
| dtype = self.text_encoder.dtype if self.text_encoder is not None else self.transformer.dtype | ||
| text_ids = torch.zeros(batch_size, prompt_embeds.shape[1], 3).to(device=device, dtype=dtype) | ||
| text_ids = text_ids.repeat(num_images_per_prompt, 1, 1) |
There was a problem hiding this comment.
To allow num_images_per_prompt > 1.
sayakpaul
commented
Aug 2, 2024
| **inputs, | ||
| ).images[0] | ||
|
|
||
| max_diff = np.abs(output_with_prompt - output_with_embeds).max() | ||
| assert max_diff < 1e-4 | ||
|
|
||
| def test_fused_qkv_projections(self): |
There was a problem hiding this comment.
It's not supported yet. Will add after @yiyixuxu performs the refactors.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
DN6
approved these changes
Aug 2, 2024
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* fix tests * fix * float64 skip * remove sample_size. * remove * remove more * default_sample_size. * credit black forest for flux model. * skip * fix: tests * remove OriginalModelMixin * add transformer model test * add: transformer model tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some comments inline.