Skip to content

Model card for mobilenet v1 and v2 #37948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 28, 2025

Conversation

yuanjua
Copy link
Contributor

@yuanjua yuanjua commented May 4, 2025

What does this PR do?

As suggested in this issue - #36979 - this PR updates the documentation of the MobilenetV1 and V2 model, which will now be aligned with the standardized format for all the docs.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stevhliu

@github-actions github-actions bot marked this pull request as draft May 4, 2025 06:57
Copy link
Contributor

github-actions bot commented May 4, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@yuanjua yuanjua marked this pull request as ready for review May 4, 2025 07:12
@github-actions github-actions bot requested a review from stevhliu May 4, 2025 07:12
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for knocking out two models at once!

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more comments to ensure v2 and v1 are the same

@yuanjua
Copy link
Contributor Author

yuanjua commented May 28, 2025

Thanks for the detailed review!

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🤗

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu force-pushed the model-card-for-mobilenet-v1-and-v2 branch from 9fd034d to c4192a2 Compare May 28, 2025 15:49
@stevhliu stevhliu merged commit 942c609 into huggingface:main May 28, 2025
10 checks passed
@yuanjua yuanjua deleted the model-card-for-mobilenet-v1-and-v2 branch May 29, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants