Skip to content

[paligemma] fix processor with suffix #38365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

zucchini-nlp
Copy link
Member

What does this PR do?

Fixes #38341 and adds a test for that

@zucchini-nlp zucchini-nlp requested a review from Cyrilvallez May 26, 2025 08:42
@zucchini-nlp zucchini-nlp added the for patch Tag issues / labels that should be included in the next patch label May 26, 2025
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@Cyrilvallez Cyrilvallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for PaliGemma, but original issue seems to indicate that it's also the case with other processors? Probably at least Gemma3 no?

@zucchini-nlp
Copy link
Member Author

Nope, gemma3 doesn't use suffix

@zucchini-nlp zucchini-nlp merged commit b0735dc into huggingface:main May 27, 2025
15 checks passed
ArthurZucker pushed a commit that referenced this pull request May 27, 2025
ArthurZucker pushed a commit that referenced this pull request May 27, 2025
ArthurZucker pushed a commit that referenced this pull request May 27, 2025
ArthurZucker pushed a commit that referenced this pull request May 27, 2025
ArthurZucker pushed a commit that referenced this pull request May 28, 2025
ArthurZucker added a commit that referenced this pull request May 30, 2025
* make it go brrrr

* date time

* update

* fix

* up

* uppp

* up

* no number i

* udpate

* fix

* [paligemma] fix processor with suffix (#38365)

fix pg processor

* [video utils] group and reorder by number of frames (#38374)

fix

* Fix convert to original state dict for VLMs (#38385)

* fix convert to original state dict

* fix

* lint

* Update modeling_utils.py

* update

* warn

* no verbose

* fginal

* ouft

* style

---------

Co-authored-by: Raushan Turganbay <raushan@huggingface.co>
Co-authored-by: hoshi-hiyouga <hiyouga@buaa.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for patch Tag issues / labels that should be included in the next patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Processors do not pass on return_tensors to tokenizers properly.
3 participants