Skip to content

[qwen-vl] Look for vocab size in text config #38372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

zucchini-nlp
Copy link
Member

@zucchini-nlp zucchini-nlp commented May 26, 2025

What does this PR do?

Fixes #38331. We had two PRs merged one after another and the current state of PR while backwards compatible, will fail when users create a new Qwen-architecture model following the new standards

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@zucchini-nlp zucchini-nlp requested a review from ArthurZucker May 26, 2025 13:09
@zucchini-nlp zucchini-nlp added the for patch Tag issues / labels that should be included in the next patch label May 27, 2025
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense hah weird that it did not fail on fast tests!

@ArthurZucker ArthurZucker merged commit baddbdd into huggingface:main May 28, 2025
15 checks passed
ArthurZucker pushed a commit that referenced this pull request May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for patch Tag issues / labels that should be included in the next patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'Qwen2VLConfig' object has no attribute 'hidden_size'
3 participants