Skip to content

Update SuperPoint model card #38896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sbucaille
Copy link
Contributor

What does this PR do?

Updates SuperPoint model card for #36979

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

Who can review?

@stevhliu

@sbucaille
Copy link
Contributor Author

@stevhliu Still a first draft, how is it possible to see the formatted result ?

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the model you contributed! ❤️

traditional corner detector. The final system gives rise to state-of-the-art homography estimation results on HPatches
when compared to LIFT, SIFT and ORB.*
> [!TIP]
> Click on the SuperPoint models in the right sidebar for more examples of how to apply SuperPoint to different computer vision tasks.

<img src="https://huggingface.co/datasets/huggingface/documentation-images/resolve/main/transformers/model_doc/superpoint_architecture.png"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move the image right after the first paragraph

@@ -117,12 +115,18 @@ plt.savefig(f"output_image.png")
```
![image/png](https://cdn-uploads.huggingface.co/production/uploads/632885ba1558dac67c440aa8/ZtFmphEhx8tcbEQqOolyE.png)

## Resources

The resources provided in the following sections consist of a list of official Hugging Face and community (indicated by 🌎) resources to help you get started with SuperPoint. If you're interested in submitting a resource to be included here, please feel free to open a Pull Request and we'll review it! The resource should ideally demonstrate something new instead of duplicating an existing resource.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace all the resources with only external links:

Refer to this [noteboook](https://github.com/NielsRogge/Transformers-Tutorials/blob/master/SuperPoint/Inference_with_SuperPoint_to_detect_interest_points_in_an_image.ipynb) for an inference and visualization example.

Comment on lines 124 to 127
<PipelineTag pipeline="keypoint-detection"/>

- [`SuperPointForKeypointDetection`] is supported by this [example script](https://github.com/huggingface/transformers/tree/main/examples/pytorch/vision) and [notebook](https://colab.research.google.com/github/huggingface/notebooks/blob/main/examples/keypoint_detection.ipynb).
- Check the [Keypoint detection task guide](../tasks/keypoint_detection) on how to use the model.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove all of this

@@ -132,13 +136,12 @@ A list of official Hugging Face and community (indicated by 🌎) resources to h

## SuperPointImageProcessor

[[autodoc]] SuperPointImageProcessor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change any of these [[autodoc]] classes here

@stevhliu
Copy link
Member

how is it possible to see the formatted result ?

I can run the build_pr_documentation job to generate a preview

@sbucaille
Copy link
Contributor Author

sbucaille commented Jun 19, 2025

@stevhliu addressed your comments, although I kept the line

- Check the [Keypoint detection task guide](../tasks/keypoint_detection) on how to use the model.

since the task exist I think it should be referred to somewhere even if there is no pipeline no ?

@stevhliu
Copy link
Member

since the task exist I think it should be referred to somewhere even if there is no pipeline no ?

I don't think the task guide adds any additional information that your model card doesn't already include so it seems a bit redundant to link to that guide.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants