MF-grabber: Add support for bottom-up image handling #1752
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi,
this PR will (re-)add support for bottom-up images in MF-grabber. The previous implementation was removed in my PR #1739, as it was based on pixelformat which was incorrect (see comments there). It's now based on image stride, information is collected in MF-grabber and processed there only once.
Tested on Windows 10 using MF-grabber with internal web-camera as top-down image source and DroidCam (free version) as bottom-up image source.
Convincing reason for adding this feature: Lord-Grey said: "Our intend is to make things as easy as possible for users, i.e. if they setup the system it should work out of the box as much as possible." Personal reason: If i break things, i have to fix them.
wbr
What kind of change does this PR introduce? (check at least one)
If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:
Fixes: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
resources used:
https://learn.microsoft.com/en-us/windows/win32/medfound/image-stride
https://learn.microsoft.com/en-us/windows/win32/medfound/mf-mt-default-stride-attribute
https://learn.microsoft.com/en-us/windows/win32/medfound/uncompressed-video-buffers