Skip to content

Implemented 16Bit HD108-Leds in HyperionNG #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

FutureMan0
Copy link
Contributor

Summary
This PR implements support for 16-bit HD108 LEDs in HyperionNG. It makes it possible to use the highspeed LEDs and adds new configuration options for HD108 LEDs.

What kind of change does this PR introduce? (check at least one)

  • Feature
  • Bugfix
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:
N/A

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:
N/A

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
This feature includes the following changes:

  • Added LedDeviceHD108.cpp and LedDeviceHD108.h for HD108 LED support.
  • Created a new JSON schema for HD108 configurations (schema-hd108.json).
  • Implemented HD108 into (content_leds.js).

@Lord-Grey
Copy link
Collaborator

@FutureMan0 Thanks for your great contribution!
May I ask you having a look at the review comments, please?

@FutureMan0
Copy link
Contributor Author

I have now implemented the changes. @Lord-Grey, could you please review the updated code? If there’s anything that still needs adjustment, feel free to let me know. The new code has also been thoroughly tested and is working as intended.

@Lord-Grey
Copy link
Collaborator

I have now implemented the changes. @Lord-Grey, could you please review the updated code? If there’s anything that still needs adjustment, feel free to let me know. The new code has also been thoroughly tested and is working as intended.

@FutureMan0 I had another look at the changes and explanations.
Please find some additional suggestions above.

@Lord-Grey Lord-Grey merged commit 5475483 into hyperion-project:master Mar 7, 2025
16 of 18 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Output Devices Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants