Skip to content

refactor: use maps.copy for cleaner map handling #4639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions db/batch/kv_cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

package batch

import "maps"

type (
// KVStoreCache is a local cache of batched <k, v> for fast query
KVStoreCache interface {
Expand Down Expand Up @@ -145,9 +147,7 @@ func (c *kvCache) Append(caches ...KVStoreCache) error {
if _, ok := c.cache[key1]; !ok {
c.cache[key1] = make(map[string]*node)
}
for key2, node := range ns {
c.cache[key1][key2] = node
}
maps.Copy(c.cache[key1], ns)
}
}
return nil
Expand Down